Posso contribuir com minhas alterações de código para que outros possam se beneficiar?


Peço desculpas pelo uso do Google Tradutor; acabei de concluir uma Prova de Conceito (POC) para um museu administrado por voluntários com o Tainacan e os curadores agora querem prosseguir. Como parte da minha POC, fiz duas alterações para atender aos requisitos deles:

  1. Na página inicial, exibi um vídeo semelhante ao do site do Met NY.
  2. Substituí o visualizador de PDF por um visualizador mais elegante.

Acredito que ambas as configurações possam ser de interesse para outros usuários do Tainacan. Supondo que os curadores concordem, qual seria a melhor maneira de discutir minha contribuição para fornecer essa funcionalidade?

Hey @Tintin, welcome to our community!

Don’t mind using translators, but you can also speak in English with us. In fact since you probably copy-pasted from the translator your message our forum ended up flagging you as a suspicious message (due to the speed of typing), but I removed that since I believe it was legit from you.

So, contributions are always welcome, but as with any open source projects, they would go through a round of checklist that maintainers like me would do:

  1. Is the feature something useful for the majority of users? For example, having a video in the home page of a site is a very specific scenario, one that might be handled nowadays by a combination of core WordPress features without needing some specific bound to the Tainacan plugin.
  2. Does the code has good quality?
  3. Does it increases too much complexity or adds third party dependencies that would later have to be maintained in terms of updates, security, etc?
  4. Should it be a core Tainacan feature or is it more suitable for a plugin?

Usually we start by opening an issue in our Github to discuss the idea. From there if there is interest people can open a Pull Request via their forks and then we evaluate the code. We certainly need to improve our documentation about contributions, in fact I’m working this week on a document for contribution guidelines, since we’re starting to receive more proposals due to the growth of the project and the increase of accessibility to coding for more people via AI.

But nevertheless, feel free to share your experience, talk more about the features, so we can see where it goes! For the PDF viewer, for example, we had previously used PDF.js library which offered better features than browser native visualizers… but since their project started changing dependencies and some of them caused security issues, we ended up moving to a more practical approach of leaving this under responsability of the browser. But it is certainly a feature that may be valid for a plugin!

Great, thanks for the information Mateus. I’ll use Github as suggested.